Get wallet pubkey id if not available #92
Merged
+38
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrei-21
reviewed
Feb 7, 2024
honey-badger/src/provider.rs
Outdated
| @@ -105,8 +105,14 @@ impl AuthProvider { | |||
| Ok(access_token) | |||
| } | |||
|
|
|||
| pub fn get_wallet_pubkey_id(&self) -> Option<String> { | |||
| self.wallet_pubkey_id.clone() | |||
| pub fn get_wallet_pubkey_id(&mut self) -> Result<String> { | |||
There was a problem hiding this comment.
Hm, maybe we do not complicate the provider, but implement it in the Auth like:
pub fn get_wallet_pubkey_id(&self) -> Result<String> {
match self.provider.lock().unwrap().get_wallet_pubkey_id() {
Some(id) => Ok(id),
None => {
self.query_token()?;
self.provider.lock().unwrap().get_wallet_pubkey_id().ok_or_permanent_failure("Failed to get pubkey id for an authenticated wallet")
}
}
}There was a problem hiding this comment.
Sure. Applied in 180fd8d.
danielgranhao
force-pushed
the
feature/get-wallet-pubkey-id-if-not-available
branch
from
4f93f87 to
180fd8d
Compare
andrei-21
approved these changes
Feb 8, 2024
danielgranhao
deleted the
feature/get-wallet-pubkey-id-if-not-available
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.